Conversation
…variables to revert
067030e to
ca36c96
Compare
This reverts commit 7d3ac98.
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new, extensible
doelaborator. Users can opt into the new elaborator by unsetting the optionbackward.do.legacy.New elaborators for the builtin
doElemsyntax category can be registered with attributedoElem_elab. For new syntax, additionally a control info handler must be registered with attributedoElem_control_infothat specifies whether the new syntaxreturns early,breaks,continues and whichmutvars it reassigns.Do elaborators have type
TSyntax `doElem → DoElemCont → DoElabM Expr, whereDoElabMis essentiallyTermElabMand theDoElemContrepresents how the rest of thedoblock is to be elaborated. Consult the docstrings for more details.Breaking Changes:
let pat := rhs | otherwiseand similar now scope over thedoSeqthat follows. Furthermore,otherwiseand the sequence that follows are nowdoSeqIndentedin order not to steal syntax from record syntax.Breaking Changes when opting into new elaborator by unsetting
backward.do.legacy:donotation now always requiresPure.do matchis now always non-dependent. There isdo match (dependent := true)that expands to aterm match as a workaround for some dependent uses.