fix: handle non-internalized terms in semiring reifier#12474
Merged
leodemoura merged 1 commit intomasterfrom Feb 14, 2026
Merged
fix: handle non-internalized terms in semiring reifier#12474leodemoura merged 1 commit intomasterfrom
leodemoura merged 1 commit intomasterfrom
Conversation
This PR fixes a panic in `grind` where `sreifyCore?` could encounter power subterms not yet internalized in the E-graph during nested propagation. The ring reifier (`reifyCore?`) already had a defensive `alreadyInternalized` check before creating variables, but the semiring reifier (`sreifyCore?`) was missing this guard. When `propagatePower` decomposed `a ^ (b₁ + b₂)` into `a^b₁ * a^b₂` and the resulting terms triggered further propagation, the semiring reifier could be called on subterms not yet in the E-graph, causing `markTerm` to fail. Closes #12428 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a panic in
grindwheresreifyCore?could encounter power subterms not yet internalized in the E-graph during nested propagation. The ring reifier (reifyCore?) already had a defensivealreadyInternalizedcheck before creating variables, but the semiring reifier (sreifyCore?) was missing this guard. WhenpropagatePowerdecomposeda ^ (b₁ + b₂)intoa^b₁ * a^b₂and the resulting terms triggered further propagation, the semiring reifier could be called on subterms not yet in the E-graph, causingmarkTermto fail.Closes #12428
🤖 Generated with Claude Code