-
Notifications
You must be signed in to change notification settings - Fork 205
Upgrade pytest-asyncio to 0.26.0 #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #652 +/- ##
==========================================
- Coverage 85.39% 85.38% -0.01%
==========================================
Files 81 96 +15
Lines 8006 8583 +577
==========================================
+ Hits 6837 7329 +492
- Misses 1169 1254 +85
🚀 New features to boost your workflow:
|
| yield ret_value | ||
|
|
||
|
|
||
| def cancel_task_if_running(task: Optional[asyncio.Task]) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is introduced to make sure we don't run into errors when trying to cancel tasks with a closed event loop. In particular, this might happen in tests once we remove the current event_loop fixture, which seems to be recommended as per the migration guide
justheuristic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR upgrades pytest_asyncio, following the migration guide given in the plugin documentation