run-vmtest: Allow specifying cpu and memory for vms #206
+25
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The max-cpu parameter is currently unused by the script and therefore vmtest defaults to 2 CPU. There is not parameter available to specify the amount of memory to give to the vm, for this the vmtest defaults to 4G. These low defaults(specifically the memory) sometimes cause the bpf seltests to sporadically fail. So, add the option to specify memory and also start using the max-cpu parameter with vmtest. Signed-off-by: Puranjay Mohan <[email protected]>
Contributor
|
@puranjaymohan this PR is very similar to #203, I am going to merge in some bits from here and update #203. run-vmtest action will check the env variables for memory and cores to set for vmtest. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The max-cpu parameter is currently unused by the script and therefore vmtest defaults to 2 CPU. There is not parameter available to specify the amount of memory to give to the vm, for this the vmtest defaults to 4G.
These low defaults(specifically the memory) sometimes cause the bpf seltests to sporadically fail. So, add the option to specify memory and also start using the max-cpu parameter with vmtest.