input: use parse_uri_raw for VMX SSH URIs to preserve %2f#143
Open
ssahani wants to merge 1 commit intolibguestfs:masterfrom
Open
input: use parse_uri_raw for VMX SSH URIs to preserve %2f#143ssahani wants to merge 1 commit intolibguestfs:masterfrom
ssahani wants to merge 1 commit intolibguestfs:masterfrom
Conversation
Use Xml.parse_uri_raw when parsing VMX SSH URIs so that percent-encoded characters like %2f are preserved in the path. On VMFS/ESXi, %2f is literal in filenames and must not be decoded. Fixes: https://issues.redhat.com/browse/RHEL-136481 Signed-off-by: Susant Sahani <ssahani@redhat.com>
Member
|
Please take a look at my comment here: https://issues.redhat.com/browse/RHEL-136481?focusedId=29157086&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-29157086 This needs more investigation as to whether it's really a bug at all, and how existing users behave, before we jump the gun with a fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Xml.parse_uri_raw when parsing VMX SSH URIs so that percent-encoded characters like %2f are preserved in the path. On VMFS/ESXi, %2f is literal in filenames and must not be decoded.
Fixes: https://issues.redhat.com/browse/RHEL-136481
Uses: libguestfs/libguestfs-common#21