-
-
Notifications
You must be signed in to change notification settings - Fork 303
SAML Support for docker #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I have one issue with this... A better way would be to install the plugins in Dockerfile during image build, all though this requires more steps to ensure things are done in the right order. |
This is by design - installing third-party plugins in the Docker image has two major drawbacks:
Note: If you don't have Internet access, you likely won't be using SAML auth anyway. This approach is a compromise - plugins are installed during container startup if needed, rather than being pre-installed. While this adds some startup time, it keeps the image lean and flexible, allowing you to use plugins only when required. The installation only occurs when the "INSTALL_PLUGINS" variable is set, so it only affects those willing to accept that startup cost. |
bump |
Here's how to add plugins during container build... just an example. As mentioned, not everyone has internet access in prod, but images can be built with internet access (i.e proxy).
|
@dot-mike Just to be clear you want me to bake all the auth plugins into the docker image? I spent some of time figuring out how not to do that because I did not want to add bloat to the image for niche users, but I can easily do that I just assumed that that would be rejected on the principle that you would not want to add a 3rd party Laravel plugin support into the image. |
for plugin in "${PLUGINS[@]}"; do | ||
echo "Installing plugin: $plugin" | ||
|
||
if ! lnms plugin:installed "$plugin"; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command does not exist :)
Added a new variable that allows the docker to install plugins that are needed for SAML.
"rebased"