Skip to content

BugFix: fluidsynth not looping if predecode is turned off #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icculus merged 1 commit into from
Nov 7, 2025
Merged

BugFix: fluidsynth not looping if predecode is turned off #779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/decoder_fluidsynth.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,12 +196,12 @@ static void *SoundFontOpen(const char *filename)
}
return ptr; // (this is actually an SDL_IOStream pointer.)
}

static int SoundFontRead(void *buf, fluid_long_long_t count, void *handle)
{
return (SDL_ReadIO((SDL_IOStream *) handle, buf, count) == count) ? FLUID_OK : FLUID_FAILED;
}

static int SoundFontSeek(void *handle, fluid_long_long_t offset, int origin)
{
SDL_IOWhence whence;
Expand All @@ -213,13 +213,13 @@ static int SoundFontSeek(void *handle, fluid_long_long_t offset, int origin)
}
return (SDL_SeekIO((SDL_IOStream *) handle, offset, whence) >= 0) ? FLUID_OK : FLUID_FAILED;
}

static int SoundFontClose(void *handle)
{
SDL_CloseIO((SDL_IOStream *) handle);
return FLUID_OK;
}

static fluid_long_long_t SoundFontTell(void *handle)
{
return SDL_TellIO((SDL_IOStream *) handle);
Expand Down Expand Up @@ -374,7 +374,14 @@ static bool SDLCALL FLUIDSYNTH_seek(void *track_userdata, Uint64 frame)
}

// !!! FIXME: docs say this will fail if a seek was requested and then a second seek happens before we play more of the midi file, since the first seek will still be in progress.
return (fluidsynth.fluid_player_seek(tdata->player, (int)ticks) == FLUID_OK);
bool result = (fluidsynth.fluid_player_seek(tdata->player, (int)ticks) == FLUID_OK);

if (result && fluidsynth.fluid_player_get_status(tdata->player) != FLUID_PLAYER_PLAYING) {
/* start playing if player is done */
result = (fluidsynth.fluid_player_play(tdata->player) == FLUID_OK);
}

return result;
#endif
}

Expand Down