Make sure s_mp_rand_source is defined for all its uses #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp_prime_rand.c uses s_mp_rand_source as well, so ensure that the latter is defined on the conditions of the former as well. Fixes libtom#582
sjaeckel
requested changes
Nov 19, 2024
| #ifdef MP_RAND_C | ||
| /* MP_RAND_C relates to mp_rand.c, MP_PRIME_RAND_C relates tp mp_prime_rand.c | ||
| Both use s_mp_rand_source */ | ||
| #if defined(MP_RAND_C) || defined(MP_PRIME_RAND_C) |
There was a problem hiding this comment.
Suggested change
| #if defined(MP_RAND_C) || defined(MP_PRIME_RAND_C) | |
| #if defined(MP_RAND_SOURCE_C) || defined(S_MP_RAND_SOURCE_C) |
This should be selected automagically via tommath_class.h, but if we change it as proposed this won't be the case. My suggestion is also not correct ... I guess the really correct way would be if the file looked as follows!? What do you think?
#include "tommath_private.h"
#ifdef S_MP_RAND_SOURCE_C
/* LibTomMath, multiple-precision integer library -- Tom St Denis */
/* SPDX-License-Identifier: Unlicense */
mp_err(*s_mp_rand_source)(void *out, size_t size) = s_mp_rand_platform;
#endif
#ifdef MP_RAND_SOURCE_C
void mp_rand_source(mp_err(*source)(void *out, size_t size))
{
s_mp_rand_source = (source == NULL) ? s_mp_rand_platform : source;
}
#endifOr maybe this should even be two files?
There was a problem hiding this comment.
I took the liberty to push https://github.com/libtom/libtommath/tree/fix-582
There was a problem hiding this comment.
Yeah that works too. I suggest you merge that, then close this PR
sjaeckel
added a commit
that referenced
this pull request
Jan 30, 2025
In order to make `helper.pl` happy, change the ternary operator to an if-else statement, otherwise it won't properly generate `tommath_class.h`. This fixes #582 This closes #583 Signed-off-by: Steffen Jaeckel <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mp_prime_rand.c uses s_mp_rand_source as well, so ensure that the
latter is defined on the conditions of the former as well.
Fixes #582