Corrected broken enum import in demoAcrossV3.ts

[S0nee]

Which Jira task belongs to this PR?

I found an error in demoAcrossV3.ts, where TransactionTypeEnum was imported incorrectly and used in the code itself, even though demoScriptHelpers exports ITransactionTypeEnum.

Initially, I assumed that the error itself was due to an incorrect export in demoScriptHelpers, and checked the demoAcrossV4.ts file, but it contained the correct import of ITransactionTypeEnum and its subsequent use.

Therefore, I corrected the import and all uses of TransactionTypeEnum to the correct ITransactionTypeEnum in demoAcrossV3.ts.

Why did I implement it this way?

Checklist before requesting a review

• I have performed a self-review of my code
• This pull request is as small as possible and only tackles one problem
• I have added tests that cover the functionality / test the bug
• For new facets: I have checked all points from this list: https://www.notion.so/lifi/New-Facet-Contract-Checklist-157f0ff14ac78095a2b8f999d655622e
• I have updated any required documentation

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

• I have checked that any arbitrary calls to external contracts are validated and or restricted
• I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
• I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

[coderabbitai]

Walkthrough

This PR updates type references in a demo script from TransactionTypeEnum to ITransactionTypeEnum across imports, type annotations, and conditional checks, while maintaining existing control flow logic.

Changes

Cohort / File(s)	Summary
Type Reference Updates script/demoScripts/demoAcrossV3.ts	Replaces TransactionTypeEnum with ITransactionTypeEnum in imports, type annotations, and all conditional comparisons; TRANSACTION_TYPE constant retyped and enum comparisons updated to interface equivalents.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

AuditNotRequired

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description provides the Jira context section and explains the issue found and how it was resolved, but the implementation reasoning section is empty and most checklists are unchecked, indicating incomplete preparation.	Complete the 'Why did I implement it this way?' section and check off applicable items in both checklists to demonstrate thorough review and testing.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: correcting an incorrect enum import from TransactionTypeEnum to ITransactionTypeEnum in demoAcrossV3.ts, which is the primary focus of this changeset.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

• ✨ 136.113.208.247/32 (new)
• 34.170.211.100/32
• 35.222.179.152/32

Failure to add the new IP will result in interrupted reviews.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

script/demoScripts/demoAcrossV3.ts (1)

12-31: ⚠️ Potential issue | 🟠 Major

Replace deprecated ethers helpers with viem-based demo helpers.

This script imports and uses deprecated ethers-based helpers (getProvider, getWalletFromPrivateKeyInDotEnv, sendTransaction, ensureBalanceAndAllowanceToDiamond) throughout, which violates the viem-only requirement for demo scripts. Migrate to the viem-based alternatives available in demoScriptHelpers: use setupEnvironment() to initialize viem clients, executeTransaction() for sending transactions, and ensureBalance() for balance checks. See demoUnit.ts for reference implementation of the correct pattern.