Simple fix for a non-working swap function

[stackoverflowed1]

Replaced the undefined variable lifiDiamondAddress with lifiDiamondContract.address in the executeWithSourceSwap function.

I chose this particular correction option because:

• it is a working option
• it is minimal

[coderabbitai]

Walkthrough

A single parameter in the executeWithSourceSwap function call is modified: lifiDiamondAddress is replaced with lifiDiamondAddress.address when passing it to getUniswapDataERC20toExactERC20. This adjusts the value used for swap data input in the chainflip demo script without altering control flow or broader logic.

Changes

Cohort / File(s)	Summary
Parameter adjustment script/demoScripts/demoChainflip.ts	Modified function argument from lifiDiamondAddress to lifiDiamondAddress.address in helper call within executeWithSourceSwap.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains what was changed and why, but is missing required template sections including Jira task reference, self-review confirmation, and reviewer checklists.	Add missing template sections: Jira task, self-review checklist items, and reviewer checklist to ensure complete PR documentation.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: fixing a non-working swap function by replacing an undefined variable.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

script/demoScripts/demoChainflip.ts (1)

76-84: ⚠️ Potential issue | 🔴 Critical

Bug: lifiDiamondAddress is not in scope — this will throw a ReferenceError at runtime.

executeWithSourceSwap is a top-level function whose parameters are lifiDiamondContract, bridgeData, chainflipData, amount, and publicClient. The variable lifiDiamondAddress is only defined inside main() (line 141) and is not accessible here. The PR description states the intent was to use lifiDiamondContract.address, which is consistent with the function's parameters.

Proposed fix

-    lifiDiamondAddress.address,
+    lifiDiamondContract.address,