Asem/v2 109/solana orders by Asem-Abdelhady · Pull Request #3 · lifinance/intent.ts

Asem-Abdelhady · 2026-03-09T21:46:25Z

This PR supports:

Solana orders
Solans orders id deriviation

It has been tested against the solana changes in lintent

reednaa

A few nits. Ideally we simplify the library rather than add to it.

src/deps.ts

src/types/solana.ts

src/intent/solana.ts

src/deps.ts

reednaa

The added files does not have test coverage unlike all other files in this repository.

Provide coverage of solanaStandard.spec.ts.

Here are a variety of agent findings:

src/intent/solanaStandard.ts

The amount field in mandateInputSchema uses "u64" but borshEncodeSolanaOrder passes BigInt(order.input.amount) — this is fine for
u64, but the amount in mandateOutputSchema uses bytes32 (big-endian 32-byte encoding), which is inconsistent. Verify this matches
the SVM program's actual layout.
The standardOrderToSolanaOrder conversion only uses the first input (order.inputs[0]), silently dropping all others. A
StandardOrder can have multiple inputs — should this throw if inputs.length > 1 rather than silently truncating?
borshEncodeSolanaOrder is exported but not re-exported from src/intent/index.ts. Intentional or oversight?

src/intent/helpers/output-encoding.ts

outputSettler is now computed per-output via getSettler?.(token.chainId) ?? COIN_FILLER — this is a meaningful behavioral change
for all EVM orders too (previously settled globally). Ensure no regression for existing EVM paths.

src/helpers/convert.ts

The early-return guard for already-bytes32 addresses is reasonable, but a Solana address (base58 string) would fail silently or
produce wrong output if passed here. The comment says "Accept only EVM addresses here" but there's no enforcement — could confuse
callers

reednaa · 2026-03-13T11:31:12Z

src/helpers/convert.ts


 export function addressToBytes32(address: `0x${string}`): `0x${string}` {
+  if (address.length === 66) return address; // already bytes32 with 0x prefix
+  if (address.length === 64) return `0x${address}`; // already bytes32 without 0x


Does this properly catch 64 length addresses prefixed with 0x?

I would rather use something like: 0x${address.replace("0x", "").padStart("0", 64)}

yeah i think we should remove if (address.length === 64) also we don't need to check the address length in address.length !== 40 for EVM since we are already constraining the template with address: 0x${string} in the parameters.

reednaa · 2026-03-13T11:31:55Z

src/intent/helpers/output-encoding.ts

    verifier,
    sameChain,
-    recipient,
+    bytes32Recipient,


I don't like using bytes32Recipient since it seems inaccurate. I would rather continue using recipient and then add natspec that recipient has to be bytes32.

reednaa · 2026-03-13T11:32:49Z

src/intent/helpers/shared.ts

+  if (lock.type === "solanaEscrow" && multichain === false)
+    return SOLANA_INPUT_SETTLER_ESCROW;


Why do we add a new lock type for Solana?

Why not add chain type or similar as the differentiator?

Since we're following the structure anyway i believe it's a good idea to commit to everything

what i'm also okay with is adding a field inside the lock that identifies the chain

reednaa · 2026-03-13T11:33:20Z

src/intent/create.ts

    const currentTime = Math.floor(Date.now() / 1000);
+    const bytes32Recipient = this.outputRecipient ? addressToBytes32(this.outputRecipient) : addressToBytes32(this.walletUser);
+
+    if (this.lock.type === "solanaEscrow") {


See previous message. This does not seem correct.

reednaa · 2026-03-13T11:33:51Z

src/intent/create.ts

    ]);

    const currentTime = Math.floor(Date.now() / 1000);
+    const bytes32Recipient = this.outputRecipient ? addressToBytes32(this.outputRecipient) : addressToBytes32(this.walletUser);


No need for bytes32Recipient. Call it recipient and add comments

reednaa · 2026-03-13T11:37:53Z

src/intent/types.ts

  asOrder(): TOrder;
  inputChains(): bigint[];
  orderId(): `0x${string}`;
-  compactClaimHash(): `0x${string}`;


This is required. Add a handler for EVM vs Solana and then provide compactClaimHash if chain is identified as EVM.

reednaa · 2026-03-13T11:39:11Z

src/intent/create.ts

+        input: {
+          token: firstInput.token.address,
+          amount: firstInput.amount,
+        },


Only 1 input? Please add verification for only 1.

Yes solana supports only one, at least for now. I agree there should be length verification

reednaa · 2026-03-13T11:40:31Z

src/intent/helpers/output-encoding.ts


-  const outputSettler = COIN_FILLER;
  return outputTokens.map(({ token, amount }) => {
+    const outputSettler = getSettler?.(token.chainId) ?? COIN_FILLER;


Potentially bad fallback for Solana consumers

reednaa · 2026-03-13T11:41:52Z

src/intent/fromOrder.ts


 export function isStandardOrder(order: OrderLike): order is StandardOrder {
-  return "originChainId" in order;
+  return "originChainId" in order && "inputs" in order;


There is no way this works. Because multichain order has inputs.

multichain does not have originChainId so there shouldn't be a problem with that

Asem-Abdelhady added 6 commits March 9, 2026 14:30

feat: support solana

348160b

chore: extra guards for address32bytes

73741b7

chore: clean changes

9ef3a04

chore: clean changes

14445f4

feat: cover solana order id

2f75746

chore: revert unnecessary changes

f7e0d0b

Asem-Abdelhady requested a review from reednaa March 9, 2026 21:55

reednaa requested changes Mar 10, 2026

View reviewed changes

src/deps.ts Outdated Show resolved Hide resolved

src/types/solana.ts Outdated Show resolved Hide resolved

src/intent/solana.ts Outdated Show resolved Hide resolved

reednaa requested changes Mar 10, 2026

View reviewed changes

src/deps.ts Show resolved Hide resolved

src/deps.ts Outdated Show resolved Hide resolved

src/deps.ts Outdated Show resolved Hide resolved

chore: Add solana to the smae structure

33b239e

Asem-Abdelhady requested a review from reednaa March 11, 2026 10:17

reednaa requested changes Mar 13, 2026

View reviewed changes

		if (lock.type === "solanaEscrow" && multichain === false)
		return SOLANA_INPUT_SETTLER_ESCROW;

Conversation

Asem-Abdelhady commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reednaa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reednaa left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Asem-Abdelhady Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Asem-Abdelhady Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Asem-Abdelhady commented Mar 9, 2026 •

edited

Loading

Asem-Abdelhady Mar 13, 2026 •

edited

Loading

Asem-Abdelhady Mar 13, 2026 •

edited

Loading