Skip to content

Fix false positive InheritedNewAbstractMethodProblem #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix false positive InheritedNewAbstractMethodProblem #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions functional-tests/src/test/trait-inherits-new-trait-with-concrete-method2-ok/app/App.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
object App {
def main(args: Array[String]): Unit = {
val b = new B {}
b.foo(1)
b.foo(-1)
}
}
Empty file added functional-tests/src/test/trait-inherits-new-trait-with-concrete-method2-ok/problems.txt
View file
Open in desktop
Empty file.
4 changes: 4 additions & 0 deletions functional-tests/src/test/trait-inherits-new-trait-with-concrete-method2-ok/v1/A.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
trait A {
def foo(a: Int) = println(s"A.foo $a")
}
trait B extends A
13 changes: 13 additions & 0 deletions functional-tests/src/test/trait-inherits-new-trait-with-concrete-method2-ok/v2/A.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
trait A {
def foo(a: Int) = println(s"A.foo $a")
}
trait AA extends A {
override def foo(a: Int) = {
if (a > 0) {
println(s"AA.foo $a")
} else {
super.foo(a)
}
}
}
trait B extends AA