Skip to content

Add Obj Det Transform Pt 2 #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 99 commits into from
Sep 29, 2025
Merged

Add Obj Det Transform Pt 2 #300

merged 99 commits into from
Sep 29, 2025

Conversation

@liopeer
Copy link
Contributor

@liopeer liopeer commented Sep 16, 2025 •
edited
Loading

What has changed and why?

  • added ScaleJitter transform
  • made transforms step/epoch aware so that we can have a stop_step/stop_epoch
  • also made some small changes to semantic segmentation transform. we can also leave these away for now and refactor later (the refactoring is anyway not complete with this PR, so might make sense to do everything separately)

What remains:

  • RandomIoUCrop

How has it been tested?

  • unit tests (might make sense to add more sophisticated ones before merging)

Did you update CHANGELOG.md?

  • Yes
  • Not needed (internal change)

Did you update the documentation?

  • Yes
  • Not needed (internal change without effects for user)

liopeer added 30 commits August 7, 2025 21:51
@liopeer
wip commit
75822ec
@liopeer
wip commit
78153fd
@liopeer
wrap up dataset
d2e86b6
@liopeer
address review
14d3c2d
@liopeer
add TaskTransforms to pydantic classes
631e420
@liopeer
Merge branch 'lionel-trn-1394-save-image-size-and-norm-info-in-model'…
bb29ee2 
… into lionel-trn-758-add-object-detection-dataset
@liopeer
add classvars to trainmodel
06a9eb9
@liopeer
Merge branch 'main' into lionel-trn-1394-save-image-size-and-norm-inf…
8cab886 
…o-in-model
@liopeer
small correction
ae5859b
@liopeer
fix model evaluation
6bbcbb4
@liopeer
make transform args available in transform interface
6b80a9d
@liopeer
Merge branch 'lionel-trn-1394-save-image-size-and-norm-info-in-model'…
7aef0c4 
… into lionel-trn-758-add-object-detection-dataset
@liopeer
wip commit
702aad9
@liopeer
address review
96814bf
@liopeer
Merge branch 'lionel-trn-1394-save-image-size-and-norm-info-in-model'…
608d685 
… into lionel-trn-758-add-object-detection-dataset
@liopeer
wip commit
9d7bd67
@liopeer
add unit tests
be6e7d9
@liopeer
Merge branch 'main' into lionel-trn-758-add-object-detection-dataset
e903042
@liopeer
fix merge
743c131
@liopeer
remove unnecessary file
ae0a286
@liopeer
remove classification files
4b22be6
@liopeer
remove is_supported_model from TrainModel
d36fec5
@liopeer
remove is_supported_model from TrainModel
d543562
@liopeer
Merge branch 'lionel-trn-758-add-object-detection-dataset' of github.…
d6e3f8b 
…com:lightly-ai/lightly-train into lionel-trn-758-add-object-detection-dataset
@liopeer
fix typing
15141dc
@liopeer
fix unit tests
df817b1
@liopeer
Merge branch 'main' into lionel-trn-758-add-object-detection-dataset
803ba59
@liopeer
handle empty lines in yolo labels
e23b305
@liopeer
explicit dtypes for arrays
37863dd
@liopeer
move logic to dataargs
102d508
stegmuel
stegmuel reviewed Sep 19, 2025
View reviewed changes
Copy link
Contributor

@stegmuel stegmuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review.

liopeer
liopeer commented Sep 25, 2025
View reviewed changes
stegmuel
stegmuel reviewed Sep 29, 2025
View reviewed changes
Copy link
Contributor

@stegmuel stegmuel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some questions/remarks.

@liopeer
remove step seeding
0b9ba5a
@liopeer
Merge branch 'lionel-trn-1520-implement-object-detection-transforms-p…
8aef613 
…t2' of github.com:lightly-ai/lightly-train into lionel-trn-1520-implement-object-detection-transforms-pt2
@liopeer
remove stop_policy from LT-DETR
883d9d5
stegmuel
stegmuel approved these changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@stegmuel stegmuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liopeer liopeer merged commit aae1940 into main Sep 29, 2025
16 checks passed
@liopeer liopeer deleted the lionel-trn-1520-implement-object-detection-transforms-pt2 branch September 29, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guarin guarin guarin left review comments

Copilot code review Copilot Copilot left review comments

@stegmuel stegmuel stegmuel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liopeer @stegmuel @guarin