Skip to content

Channel Splicing (feature 62/63) #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Channel Splicing (feature 62/63) #1160

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
43b5785
Channel Splicing (feature 62/63)
t-bast May 2, 2024
4ce4b9c
Make `splice_locked` atomic on reestablish
t-bast Jan 24, 2025
aa03076
Clarify announcement requirements
t-bast Feb 12, 2025
1d5e0ce
Clarify that `batch` can only be used when greater than 1
t-bast Mar 27, 2025
29ca2a8
Clarify 0-conf support
t-bast Mar 27, 2025
e587360
Clarify `splice_locked` retransmission
t-bast May 15, 2025
765a80e
Introduce a `start_batch` message for `commit_sig`
t-bast May 15, 2025
2822a52
Add more reestablish test vectors to splicing-test.md (#5)
remyers Jun 2, 2025
b36ab0c
Always set `commit_sig.funding_txid`
t-bast Jun 11, 2025
a821628
Add `message_type` TLV to `start_batch`
t-bast Jun 11, 2025
e010513
Clarify various requirements
t-bast Jun 11, 2025
81b89a6
Restrict `start_batch` to splicing use-cases
t-bast Jun 17, 2025
04cdc02
Clarify `channel_ready` and `splice_locked` retransmit
t-bast Jun 23, 2025
c0d9c52
fixup! Clarify `channel_ready` and `splice_locked` retransmit
t-bast Jun 25, 2025
f9fd539
Re-work `my_current_funding_locked` reestablish
t-bast Aug 12, 2025
f6346ba
Clarify `tx_signatures` ordering
t-bast Sep 23, 2025
ea25a7e
Avoid `channel_ready` retransmission after splice
t-bast Sep 24, 2025
f5fcdbf
fixup! Avoid `channel_ready` retransmission after splice
t-bast Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions 02-peer-protocol.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3387,7 +3387,8 @@ The sending node:

A node:
- if `next_commitment_number` is 1 in both the `channel_reestablish` it
sent and received:
sent and received, and none of those `channel_reestablish` messages
contain `my_current_funding_locked` for a splice transaction:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this also consider next_funding_txid for a splice transaction as well to cover the reestablish cases where we still need to retransmit commitment_signed/tx_signatures? Sending splice_init already requires that both sides have received channel_ready.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point, done in f5fcdbf 👍

- MUST retransmit `channel_ready`.
- otherwise:
- MUST NOT retransmit `channel_ready`, but MAY send `channel_ready` with
Expand Down Expand Up @@ -3516,10 +3517,10 @@ commitment number 0 is created during opening.
`commitment_signed` for commitment number 1 is send and then
the revocation for commitment number 0 is received.

`channel_ready` is implicitly acknowledged by the start of normal
operation, which is known to have begun after a `commitment_signed` has been
received — hence, the test for a `next_commitment_number` greater
than 1.
`channel_ready` is implicitly acknowledged by the start of normal operation,
which is known to have begun after a `commitment_signed` has been received
(hence, the test for a `next_commitment_number` greater than 1) or after a
splice transaction has been locked.

A node, which has somehow fallen
behind (e.g. has been restored from old backup), can detect that it has fallen
Expand Down