Skip to content

Conversation

@G8XSU
Copy link
Contributor

@G8XSU G8XSU commented Mar 5, 2025

  • Start storing payments using PaginatedKVStore.
  • API changes to support pagination in ListPayments.
  • Support pagination in ListPayments API.

@G8XSU G8XSU requested a review from jkczyz March 5, 2025 22:33
@G8XSU G8XSU added the Weekly Goal Someone wants to land this this week label Mar 5, 2025
@G8XSU
Copy link
Contributor Author

G8XSU commented Mar 6, 2025

Ignore the build error, adding another commit to fix CLI.

@G8XSU
Copy link
Contributor Author

G8XSU commented Mar 6, 2025

Pushed additional commits to fix CI for CLI build.

@G8XSU G8XSU requested a review from jkczyz March 7, 2025 21:00
@G8XSU G8XSU requested a review from jkczyz March 7, 2025 21:45
Copy link
Contributor

@jkczyz jkczyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , please squash.

@G8XSU G8XSU force-pushed the payments-pagination-2 branch from 94de2da to 4655037 Compare March 7, 2025 21:58
@G8XSU
Copy link
Contributor Author

G8XSU commented Mar 7, 2025

Squashed fixups !

@G8XSU G8XSU requested a review from jkczyz March 7, 2025 22:00
@G8XSU G8XSU merged commit 9241a4a into lightningdevkit:main Mar 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Weekly Goal Someone wants to land this this week

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants