Skip to content

Conversation

@elnosh
Copy link
Contributor

@elnosh elnosh commented Dec 11, 2025

Don't think this needs to be macro.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Dec 11, 2025

I've assigned @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.35%. Comparing base (18cebae) to head (3247fad).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channelmanager.rs 88.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4279      +/-   ##
==========================================
- Coverage   89.36%   89.35%   -0.01%     
==========================================
  Files         180      180              
  Lines      139827   139847      +20     
  Branches   139827   139847      +20     
==========================================
+ Hits       124956   124961       +5     
- Misses      12280    12297      +17     
+ Partials     2591     2589       -2     
Flag Coverage Δ
fuzzing 35.21% <84.00%> (+0.01%) ⬆️
tests 88.69% <88.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joostjager
Copy link
Contributor

Let's continue the macro removal trend

@joostjager joostjager merged commit 593d6aa into lightningdevkit:main Dec 12, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants