-
Couldn't load subscription status.
- Fork 109
build: bump go to v1.24.9 #1160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @ZZiigguurraatt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a critical infrastructure update, specifically bumping the Go language version used across the project from Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Go version from 1.24.6 to 1.24.9. The change is applied consistently across all relevant files, including go.mod files for the main module and submodules, Dockerfiles (with updated image digests), and the Makefile. The update is necessary to support a newer version of lnd as mentioned in the description. The changes are correct and look good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this 🙏!
As of lnd commit lightningnetwork/lnd@4fc8d8d, golang version
1.24.9is required.I'm not sure if #1159 should be closed in favor of this one or if we should merge #1159 first and them make a litd RC with lnd version
v0.20.0-beta.rc2with golang1.24.8? Not sure of the differences between these golang versions so someone else with more expertise should weigh in on which PR to use, but both are available to look review and merge at this time.