[SBA-02b] migrate from deprecated tslint to typescript-eslint

[jamaljsr]

Summary

The tslint package has been deprecated for many years and has been replaced by typescript-eslint. This PR migrates the packages and config to the currently recommended linter.

There are no functional changes, just some updates to the code to pass the new recommended linter ruleset.

Steps to Test

1. Run yarn install to install the new dependencies
2. Run yarn lint to confirm all code passes the linter checks
3. Run yarn build to ensure the build still works

Related Issues & Pull Requests

• Session-Based Authentication & Passkeys #128

Depends on:

• [SBA-02] update typescript and add typecheck script #131
• [SBA-01] chore: normalize indentation to 2 spaces #130

[jbrill]

Great change! Just a few minor ts-related suggestions/thoughts

[jbrill]

This might be a good project to add eslint-plugin-security if we wanted.

[jamaljsr]

Are there any specific rules that you think we need? I tried using this on the fully implemented POC branch and it only produced a bunch of false positives on the detect-object-injection rule, like this example which is valid. I don't really see the benefit of adding this if it's going to cause us to have to add a bunch of ignores to the codebase.

[jbrill]

The main thing I was thinking about was some XSS detection in the future, but was just a though/suggestion.

[jamaljsr]

@jbrill Thanks for the review. I've addressed all of your feedback. This is ready for another pass.

[jbrill]

LGTM 👌