Skip to content

Conversation

starius
Copy link
Contributor

@starius starius commented Jun 28, 2025

Add fields: CommitHash, BestBlockHash, Color, NumPeers.

Pull Request Checklist

  • PR is opened against correct version branch.
  • Version compatibility matrix in the README and minimal required version
    in lnd_services.go are updated.
  • Update macaroon_recipes.go if your PR adds a new method that is called
    differently than the RPC method it invokes.

Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 🎉

@guggero
Copy link
Contributor

guggero commented Jun 30, 2025

Unit test fails.

Add fields: CommitHash, BestBlockHash, Color, NumPeers.
@starius starius force-pushed the getinfo-more-fields branch from e9346a4 to 3e14d69 Compare June 30, 2025 21:29
@starius
Copy link
Contributor Author

starius commented Jun 30, 2025

Fixed the unit test.

@guggero guggero merged commit 6c62860 into lightninglabs:master Jul 1, 2025
1 check passed
@starius starius deleted the getinfo-more-fields branch July 1, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants