RegisterSpendNtfn: support reorg channel #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starius
added a commit
to starius/loop
that referenced
this pull request
Jul 9, 2025
Include lightninglabs/lndclient#233 RegisterSpendNtfn: support reorg channel TODO: remove replace in go.mod
starius
added a commit
to starius/loop
that referenced
this pull request
Jul 9, 2025
Include lightninglabs/lndclient#233 RegisterSpendNtfn: support reorg channel TODO: remove replace in go.mod
guggero
suggested changes
Jul 9, 2025
chainnotifier_client.go
Outdated
| return | ||
| } | ||
|
|
||
| opts.ReOrgChan <- struct{}{} |
There was a problem hiding this comment.
I think we should also listen on ctx.Done() here, see RegisterConfirmationsNtfn.
There was a problem hiding this comment.
On the same note, I think we should also do this before writing to the errChan (and fix conf notifier too).
There was a problem hiding this comment.
I updated sending to ReOrgChan (listening for ctx.Done()).
errChan is used at most one time and it is buffered, has capacity 1.
But I think that we should listen for ctx.Done() when sending to spendChan and confChan. These channels have capacity 1, but can be used multiple times.
There was a problem hiding this comment.
Added this in another commit.
The corresponding API of LND already supports notifying the caller about a reorg. I reused NotifierOption's used for RegisterConfirmationsNtfn already to pass a channel notified upon a reorg affecting a reported confirmation.
Avoid a deadlock in case the caller doesn't consume notifications about spending or confirmations after cancelling a call.
guggero
approved these changes
Jul 9, 2025
|
Pushed a new tag: |
starius
added a commit
to starius/loop
that referenced
this pull request
Jul 9, 2025
Include lightninglabs/lndclient#233 RegisterSpendNtfn: support reorg channel
starius
added a commit
to starius/loop
that referenced
this pull request
Jul 10, 2025
Include lightninglabs/lndclient#233 RegisterSpendNtfn: support reorg channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corresponding API of LND already supports notifying the caller about a reorg. I reused NotifierOption's used for RegisterConfirmationsNtfn already to pass a channel notified upon a reorg affecting a reported confirmation.
Pull Request Checklist
in
lnd_services.goare updated.macaroon_recipes.goif your PR adds a new method that is calleddifferently than the RPC method it invokes.