multi: bump lnd compile time dependency to v0.18.4-beta #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
97e7c91 to
066ae26
Compare
21 tasks
|
This can be reviewed now? |
No, we need an RC of |
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
066ae26 to
4118e76
Compare
|
Bumped to |
bhandras
reviewed
Oct 14, 2024
starius
reviewed
Oct 22, 2024
loopout_test.go
Outdated
Comment on lines
891
to
894
| payAddr, err := invoice.PaymentAddr.UnwrapOrErr( | ||
| fmt.Errorf("expected payment address"), | ||
| ) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
I propose to use:
payAddr := invoice.PaymentAddr.UnwrapOrFail(t)There was a problem hiding this comment.
Ah, I forgot UnwrapOrFail() existed, makes perfect sense here. Changed.
starius
approved these changes
Oct 22, 2024
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
4118e76 to
93525d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the (not-yet-merged)
lnd v0.18.4-betaversion.Depends on lightningnetwork/lnd#8960.
Depends on lightninglabs/lndclient#192.
Full serialized dependency list can be seen here: lightninglabs/lightning-terminal#848
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes