-
Notifications
You must be signed in to change notification settings - Fork 138
Burn assets by group key #1812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 0-8-0-staging
Are you sure you want to change the base?
Burn assets by group key #1812
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
13a399f
to
9cd15a7
Compare
9cd15a7
to
7c6e2ba
Compare
Pull Request Test Coverage Report for Build 18141060997Details
💛 - Coveralls |
a9fc25c
to
544f5b4
Compare
c0a0cae
to
c3082d6
Compare
@GeorgeTsagk: review reminder |
I think this should have base branch |
c3082d6
to
c22bcbe
Compare
comments applied (and answered) and pointed to |
86b225f
to
ca49ac9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getting there
some final Qs
rpcserver.go
Outdated
in.AmountToBurn) | ||
// If the asset ID is set but the group key is not, we need to query | ||
// the asset group by the asset ID to get the group key. | ||
if assetID != nil && groupKey == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we're also silently dropping support for burning a specific asset ID. With this line we're always trying to find the group and burn based on the group key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous behavior stays unchanged regarding asset ID. As you can see, this was also done before but I moved it outside of the switch to support both using the old Asset
and the new AssetSpecifier
.
If I somehow changed the logic, it isn't intended.
Allow the creation of multiple vPackets when burning by group key.
Return multiple proofs in BurnAssetResponse.
ca49ac9
to
24569f4
Compare
Enable burning of assets by specifying a group key.
AssetSpecifier
totapcommon.proto
and use it in theBurnAssetRequest
tapcli
to acceptgroup_key
param intapd assets burn
commandstapfreighter
to support passing a group key in the asset specifierBurnAsset
RPC request to accept anAssetSpecifier
. Breaking change!Example: