Skip to content

Conversation

Roasbeef
Copy link
Member

We also update the version pinned in the go.mod files to Go 1.24.8.

We also update the version pinned in the go.mod files to Go 1.24.8.
@Roasbeef Roasbeef requested review from a team, GeorgeTsagk and darioAnongba and removed request for a team October 10, 2025 11:36
Copy link

Summary of Changes

Hello @Roasbeef, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the Go language versions utilized throughout the project's development and build infrastructure. It upgrades the Go version for all Docker-based build environments and the primary Makefile to Go 1.25.2, ensuring that the project benefits from the latest stable Go release for its compilation and testing processes. Concurrently, the minimum Go version declared in the project's go.mod files has been advanced to Go 1.24.8, aligning module requirements with a more recent and stable patch release of the Go 1.24 series.

Highlights

  • Go Version Update for CI/Build: The Go version used for building, CI, and Docker images has been updated from 1.24.6 to 1.25.2 across various Dockerfiles and the Makefile.
  • Go Module Requirement Update: The minimum Go version specified in the go.mod files for the main module and sub-modules has been updated from 1.24.6 to 1.24.8.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/main.yaml
    • .github/workflows/release.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go version for CI/release builds to 1.25.2 and the minimum required Go version in go.mod files to 1.24.8. The changes are consistent and correct across all modified files. I've added a couple of suggestions to also update the dependencies in the tools and taprpc sub-modules to keep them in sync with the root module, which would improve maintainability and prevent potential tooling or build issues.

module github.com/lightninglabs/taproot-assets/tools

go 1.24.6
go 1.24.8

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While updating the Go version, it's a good opportunity to synchronize dependencies with the root go.mod. This file uses btcd v0.24.2, while the root go.mod uses a newer version (v0.24.3-0...). Using outdated dependencies for development tools can sometimes lead to incorrect analysis. Please consider running go get -u and go mod tidy in the tools directory to align the dependencies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point here for the tools.

module github.com/lightninglabs/taproot-assets/taprpc

go 1.24.6
go 1.24.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we bump this to 1.25.2 also? The linter might fail.
Same for tools/go.mod

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically make sure we support building with the last two Go versions. Changing this would mean you can't build with Go 1.24.

module basic-price-oracle

go 1.24.6
go 1.24.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 1.25.2 also?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 18405332273

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 28010 unchanged lines in 195 files lost coverage.
  • Overall coverage decreased (-15.0%) to 34.621%

Files with Coverage Reduction New Missed Lines %
universe/supplyverifier/util.go 1 98.75%
proof/util.go 2 81.63%
tapdb/migrations.go 2 76.19%
address/log.go 3 0.0%
commitment/log.go 3 0.0%
internal/pedersen/commitment.go 3 95.31%
lndservices/log.go 3 0.0%
rfq/log.go 3 0.0%
tapchannel/log.go 3 0.0%
tapdb/supply_syncer.go 3 73.85%
Totals Coverage Status
Change from base Build 18359865357: -15.0%
Covered Lines: 30550
Relevant Lines: 88240

💛 - Coveralls

Copy link
Contributor

@darioAnongba darioAnongba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Gemini's comment about btcd unrelated to this PR.

module github.com/lightninglabs/taproot-assets/tools

go 1.24.6
go 1.24.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point here for the tools.

Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@levmi levmi moved this from 🆕 New to 🏗 In progress in Taproot-Assets Project Board Oct 13, 2025
@levmi levmi moved this from 🏗 In progress to 👀 In review in Taproot-Assets Project Board Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

5 participants