-
Notifications
You must be signed in to change notification settings - Fork 138
build: update CI+release version to Go 1.25.2 #1847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We also update the version pinned in the go.mod files to Go 1.24.8.
Summary of ChangesHello @Roasbeef, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the Go language versions utilized throughout the project's development and build infrastructure. It upgrades the Go version for all Docker-based build environments and the primary Makefile to Go 1.25.2, ensuring that the project benefits from the latest stable Go release for its compilation and testing processes. Concurrently, the minimum Go version declared in the project's Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Go version for CI/release builds to 1.25.2 and the minimum required Go version in go.mod
files to 1.24.8. The changes are consistent and correct across all modified files. I've added a couple of suggestions to also update the dependencies in the tools
and taprpc
sub-modules to keep them in sync with the root module, which would improve maintainability and prevent potential tooling or build issues.
module github.com/lightninglabs/taproot-assets/tools | ||
|
||
go 1.24.6 | ||
go 1.24.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While updating the Go version, it's a good opportunity to synchronize dependencies with the root go.mod
. This file uses btcd v0.24.2
, while the root go.mod
uses a newer version (v0.24.3-0...
). Using outdated dependencies for development tools can sometimes lead to incorrect analysis. Please consider running go get -u
and go mod tidy
in the tools
directory to align the dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point here for the tools.
module github.com/lightninglabs/taproot-assets/taprpc | ||
|
||
go 1.24.6 | ||
go 1.24.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we bump this to 1.25.2
also? The linter might fail.
Same for tools/go.mod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We typically make sure we support building with the last two Go versions. Changing this would mean you can't build with Go 1.24.
module basic-price-oracle | ||
|
||
go 1.24.6 | ||
go 1.24.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 1.25.2 also?
Pull Request Test Coverage Report for Build 18405332273Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Gemini's comment about btcd
unrelated to this PR.
module github.com/lightninglabs/taproot-assets/tools | ||
|
||
go 1.24.6 | ||
go 1.24.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point here for the tools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
We also update the version pinned in the go.mod files to Go 1.24.8.