[Part 6|*] Thread Contexts through payment methods Part 2 #10308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziggie1984
changed the base branch from
master
to
elle-payment-sql-series-new
6 tasks
ziggie1984
force-pushed
the
introduce-sql-schema-payments-part-6
branch
from
d78c447 to
7e67836
Compare
ziggie1984
force-pushed
the
introduce-sql-schema-payments-part-6
branch
from
7e67836 to
bf83aca
Compare
ziggie1984
force-pushed
the
elle-payment-sql-series-new
branch
4 times, most recently
from
e991cd0 to
6860702
Compare
Previously a one(intent)-to-many(payment) relationship it is now changed to a one-to-one relationship because a payment request only can have 1 payment related to it. Looking into the future with BOLT12 offers, the fetched invoice from the offer could be stored here as well and the relationship would still hold.
In this commit we add all queries which we will need to insert payment related data into the db.
ziggie1984
force-pushed
the
introduce-sql-schema-payments-part-6
branch
from
bf83aca to
90a87b0
Compare
A context is added to failPaymentAndAttempt and its dependant function calls.
ziggie1984
force-pushed
the
introduce-sql-schema-payments-part-6
branch
from
90a87b0 to
49087c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of the Context Threading refactor. Depends on #10307