-
Notifications
You must be signed in to change notification settings - Fork 4
Added gamez, maybe correctly; please check #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Most of it looks good but in the icon field it currently only accepts URLs that point to a PNG image... And also for it to show up in Moss you will also need to add the tool into the curations list ( |
|
@matthme Can you check now? I was confused by what it meant by the toolListURL on the curation list. I added the raw link of Github, but that doesn't make much sense. |
0.13/lists/curations-0.13.json
Outdated
| "tools": [] | ||
| "tools": [ | ||
| { | ||
| "toolListUrl": "https://raw.githubusercontent.com/lightningrodlabs/weave-tool-curation/refs/heads/main/0.13/lists/tool-list-0.13.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one needs to be changed to https://lightningrodlabs.org/weave-tool-curation/0.13/tool-list-0.13.json
Not obvious, sorry but that's the URL it will be at after getting published upon merging into the main branch. And since this URL is also used as part of the identifier we want to use the lightningrodlabs URL and not the github URL since we're in control of the former.
|
#3 built on the changes from this PR so we can close this one. |
Hey Matt, please take a look see if it's like it should.