Skip to content

Conversation

@Zequez
Copy link
Contributor

@Zequez Zequez commented Dec 23, 2024

Hey Matt, please take a look see if it's like it should.

@matthme
Copy link
Collaborator

matthme commented Dec 23, 2024

Most of it looks good but in the icon field it currently only accepts URLs that point to a PNG image...

And also for it to show up in Moss you will also need to add the tool into the curations list (curations-0.13.ts)

@Zequez
Copy link
Contributor Author

Zequez commented Dec 31, 2024

@matthme Can you check now? I was confused by what it meant by the toolListURL on the curation list. I added the raw link of Github, but that doesn't make much sense.

"tools": []
"tools": [
{
"toolListUrl": "https://raw.githubusercontent.com/lightningrodlabs/weave-tool-curation/refs/heads/main/0.13/lists/tool-list-0.13.json",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one needs to be changed to https://lightningrodlabs.org/weave-tool-curation/0.13/tool-list-0.13.json

Not obvious, sorry but that's the URL it will be at after getting published upon merging into the main branch. And since this URL is also used as part of the identifier we want to use the lightningrodlabs URL and not the github URL since we're in control of the former.

matthme
matthme previously approved these changes Jan 4, 2025
@matthme
Copy link
Collaborator

matthme commented Jan 4, 2025

#3 built on the changes from this PR so we can close this one.

@matthme matthme closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants