Reconnect smtp_server instance if not connected#478
Open
broper2 wants to merge 1 commit intoliiight:mainfrom
Open
Reconnect smtp_server instance if not connected#478broper2 wants to merge 1 commit intoliiight:mainfrom
broper2 wants to merge 1 commit intoliiight:mainfrom
Conversation
Contributor
Author
|
hi @liiight wanted to check in on this. i am eager to get this merged and packaged in a notifiers release such that we can pull it into our application. the failure case this prevents poses a big risk |
|
We use this at my work and I'd love to see this get merged. We haven't seen the bug yet but I'm scared of what could happen if it does because we rely so heavily on notifiers for our email alerting |
Contributor
Author
|
hello @liiight, checking in on this again - would you please provide a timeline when i might be able to get a review on this? thanks |
Contributor
Author
|
hello @liiight can you please provide some clarity whether this change will ever be accepted? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the notifiers implementation of an email provider makes a connection to the mail server and reuses that as long as the further email payloads are meant to be sent through the same "configured" mail server connection. in python's source code for smtplib.py, they note that the connection (of an SMTP instance) is kept open even if an exception is raised in sendmail. However, this is not true in the case of a timeout communicating with the mail server (code 421), see source code here.
Given this, we were seeing issues in our application which uses notifiers library where we would get a timeout communicating with the mail server (which can happen for a variety of reasons) and then all of the following email requests would fail with with this error because the connection was closed.
This PR makes it such that we check whether the connection is still alive before reusing it to send the email, else it tries to establish a new connection.