Introduce SettableWatcher to make writing Watcher related integration…#693
Open
Introduce SettableWatcher to make writing Watcher related integration…#693
Conversation
… test more easily
imasahiro
requested review from
ikhoon,
jrhee17,
minwoox and
trustin
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
============================================
- Coverage 70.19% 70.06% -0.14%
+ Complexity 3419 3414 -5
============================================
Files 349 350 +1
Lines 13468 13487 +19
Branches 1454 1457 +3
============================================
- Hits 9454 9449 -5
- Misses 3133 3154 +21
- Partials 881 884 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ikhoon
reviewed
May 23, 2022
| import com.linecorp.centraldogma.client.Watcher; | ||
| import com.linecorp.centraldogma.common.Revision; | ||
|
|
||
| public final class SettableWatcher<T> implements Watcher<T> { |
Contributor
There was a problem hiding this comment.
Would you mind adding Javadoc and simple test suites to ensure the feature?
| updateListeners.clear(); | ||
| } | ||
|
|
||
| public void setValue(T value) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… test more easily