Faster signatures #105
Open
Faster signatures #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Huge increase of performance in signing/verifying WITHOUT timing variations that could leak information about secret keys (that made PR dchest#134 unmergeable) ┌───────────────────────────────────────────────────────────────────────────────┐ │ PERFORMANCE IMPROVEMENTS SUMMARY │ ├───────────────────────────────────────────────────────────────────────────────┤ │ • Signing: ~2x faster on M4 Max compared to current implementation │ │ (slightly slower than previous solution) │ │ │ │ • Verification: ~40x faster than current implementation │ │ (~20x faster than previous PR dchest#134 solution) │ │ │ ├───────────────────────────────────────────────────────────────────────────────┤ │ BENCHMARK RESULTS │ ├─────────────────────────────────────────────────────────────────────────────────────────────┤ │ On M4 Max (MBP Nov 2024), tested in Chrome Version 134.0.6998.89 - arm64: │ │ │ │ THIS PR │ │ sign 787 ops 0.64 ms/op 1573.69 ops/sec [+91.1%] │ │ sign.open 8641 ops 0.06 ms/op 17261.29 ops/sec [+4067.3%] │ │ │ │ PR dchest#134 with risk of timing attacks │ │ sign 889 ops 0.56 ms/op 1775.51 ops/sec [+115.6%] │ │ sign.open 454 ops 1.10 ms/op 906.55 ops/sec [+118.9%] │ │ │ │ CURRENT IMPLEMENTATION │ │ sign 412 ops 1.21 ms/op 823.34 ops/sec - │ │ sign.open 208 ops 2.41 ms/op 414.18 ops/sec - │ └─────────────────────────────────────────────────────────────────────────────────────────────┘
Huge increase of performance in signing/verifying WITHOUT timing variations that could leak information about secret keys (that made PR dchest#134 unmergeable) ┌───────────────────────────────────────────────────────────────────────────────┐ │ PERFORMANCE IMPROVEMENTS SUMMARY │ ├───────────────────────────────────────────────────────────────────────────────┤ │ • Signing: ~2x faster on M4 Max compared to current implementation │ │ (slightly slower than previous solution) │ │ │ │ • Verification: ~40x faster than current implementation │ │ (~20x faster than previous PR dchest#134 solution) │ │ │ ├───────────────────────────────────────────────────────────────────────────────┤ │ BENCHMARK RESULTS │ ├─────────────────────────────────────────────────────────────────────────────────────────────┤ │ On M4 Max (MBP Nov 2024), tested in Chrome Version 134.0.6998.89 - arm64: │ │ │ │ THIS PR │ │ sign 787 ops 0.64 ms/op 1573.69 ops/sec [+91.1%] │ │ sign.open 8641 ops 0.06 ms/op 17261.29 ops/sec [+4067.3%] │ │ │ │ PR dchest#134 with risk of timing attacks │ │ sign 889 ops 0.56 ms/op 1775.51 ops/sec [+115.6%] │ │ sign.open 454 ops 1.10 ms/op 906.55 ops/sec [+118.9%] │ │ │ │ CURRENT IMPLEMENTATION │ │ sign 412 ops 1.21 ms/op 823.34 ops/sec - │ │ sign.open 208 ops 2.41 ms/op 414.18 ops/sec - │ └─────────────────────────────────────────────────────────────────────────────────────────────┘
Test run and benchmark run on PR
…nto faster-signatures
Benchmark Comparison for nacl-fast.min.jsRaw Results (PR Branch)Performance Delta (PR vs master)
Note: Changes within ±10% are considered neutral due to normal benchmark variation. This threshold aligns with common benchmarking practices in JavaScript engines and Node.js projects. |
Benchmark Comparison for nacl.jsRaw Results (PR Branch)Performance Delta (PR vs master)
Note: Changes within ±10% are considered neutral due to normal benchmark variation. This threshold aligns with common benchmarking practices in JavaScript engines and Node.js projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.