Skip to content

Conversation

@abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Dec 30, 2025

Description 📝

This PR removes the much involved iamRbacPrimaryNavChanges which has now been the default for a few months.

It defaults Cloud Manager to use the true value of the flag while keeping the redirects (ie: /account/billing 👉 /billing etc) for backward compatibility. Those redirects could eventually be removed as a secondary cleanup.

This change will change nothing for our users, it justs cleans up obsolete logic for a flag having reached deprecation status.

Changes 🔄

  • Remove iamRbacPrimaryNavChanges feature flag logic
  • Update e2e tests
  • Update unit tests

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Preview 📷

There shouldn't be any functional or visual regression a part of this PR.

How to test 🧪

Verification steps

⚠️ The steps below should be tested with both an IAM enabled account and an IAM without the customer tag (iam_beta)
The steps should be also compared to the current production behavior (no regression)

  • Verify Primary Navigation behaves as expected
    • items
    • order
    • destination
  • Confirm all profile pages behave as expected
  • Confirm redirects (account/<feature> to <feature>
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@abailly-akamai abailly-akamai changed the title chore: [UIE-9913] - IAM: Cleanup iamRbacPrimaryNavChanges route chore: [UIE-9913] - IAM: Cleanup iamRbacPrimaryNavChanges feature flag Jan 2, 2026
@abailly-akamai abailly-akamai changed the title chore: [UIE-9913] - IAM: Cleanup iamRbacPrimaryNavChanges feature flag chore: [UIE-9913] - IAM: Cleanup iamRbacPrimaryNavChanges feature flag Jan 2, 2026
@abailly-akamai abailly-akamai marked this pull request as ready for review January 2, 2026 13:02
@abailly-akamai abailly-akamai requested review from a team as code owners January 2, 2026 13:02
@abailly-akamai abailly-akamai requested review from cliu-akamai and removed request for a team January 2, 2026 13:02
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Routing and redirects work from my testing!

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be unrelated but the deep link to the "Edit Account Drawer" doesnt work how I'd expect. If I refresh, it closes itself.

Screen.Recording.2026-01-05.at.10.54.33.AM.mov

@abailly-akamai
Copy link
Contributor Author

@bnussman-akamai - thanks! good call, fixed the small issue with the billing drawers

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #9 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing864 Passing11 Skipped42m 47s

Details

Failing Tests
SpecTest
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

3 participants