-
Notifications
You must be signed in to change notification settings - Fork 391
chore: [UIE-9913] - IAM: Cleanup iamRbacPrimaryNavChanges feature flag
#13232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
da915af to
58d7065
Compare
iamRbacPrimaryNavChanges routeiamRbacPrimaryNavChanges feature flag
iamRbacPrimaryNavChanges feature flagiamRbacPrimaryNavChanges feature flag
bnussman-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Routing and redirects work from my testing!
bnussman-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be unrelated but the deep link to the "Edit Account Drawer" doesnt work how I'd expect. If I refresh, it closes itself.
Screen.Recording.2026-01-05.at.10.54.33.AM.mov
|
@bnussman-akamai - thanks! good call, fixed the small issue with the billing drawers |
Cloud Manager UI test results🔺 1 failing test on test run #9 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||
Description 📝
This PR removes the much involved
iamRbacPrimaryNavChangeswhich has now been the default for a few months.It defaults Cloud Manager to use the true value of the flag while keeping the redirects (ie:
/account/billing👉/billingetc) for backward compatibility. Those redirects could eventually be removed as a secondary cleanup.This change will change nothing for our users, it justs cleans up obsolete logic for a flag having reached deprecation status.
Changes 🔄
iamRbacPrimaryNavChangesfeature flag logicScope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
There shouldn't be any functional or visual regression a part of this PR.
How to test 🧪
Verification steps
iam_beta)The steps should be also compared to the current production behavior (no regression)
account/<feature>to<feature>Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅