Conversation
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds redirect URL validation to authentication endpoints to mitigate open-redirect risks, and introduces persistent security audit logging for invalid redirect attempts.
Changes:
- Introduces redirect validation/sanitization helpers (
isValidRedirectUrl,getSafeRedirectUrl) with an allow-list for absolute redirects. - Adds a
security_audit_logstable and a repository for writing security events. - Updates auth endpoints (login/callback/logout) and DB middleware to validate/log redirect attempts and ensure DB access is available on those routes.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/server/utils/redirect.ts | New redirect validation + sanitization helpers and allow-list logic. |
| frontend/server/repo/securityAudit.repo.ts | New repository for writing security audit events to Postgres. |
| frontend/server/middleware/database.ts | Expands DB-pool attachment to auth routes (not just chat). |
| frontend/server/api/auth/logout.post.ts | Adds optional returnTo handling with validation + audit logging. |
| frontend/server/api/auth/login.get.ts | Validates redirectTo and logs invalid attempts before setting cookie. |
| frontend/server/api/auth/callback.ts | Defense-in-depth validation of redirect cookie + logs possible tampering. |
| database/migrations/V1770789662__createSecurityAuditLogsTable.sql | Adds security_audit_logs table + indexes + event-type check constraint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
gaspergrom
requested changes
Feb 12, 2026
joanagmaia
approved these changes
Feb 13, 2026
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
gaspergrom
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR
Ticket
IN-973