Skip to content

[WIP] Refactor label and button initialization to use keywords #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Refactor label and button initialization to use keywords #561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions nemo-terminal/src/nemo-terminal-prefs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ class LabeledItem(Gtk.Box):
def __init__(self, label, item):
super(LabeledItem, self).__init__(orientation=Gtk.Orientation.HORIZONTAL)

self.label_widget = Gtk.Label(label)
# Fixed: Use keyword argument instead of positional
Copy link
Member

@mtwebster mtwebster Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there's no need for these comments - git shows us what has changed, and your commit message tells us why.

Copy link
Member

@clefebvre clefebvre Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is usually added by AI.

self.label_widget = Gtk.Label(label=label)

self.pack_start(self.label_widget, False, False, 6)
self.pack_end(item, False, False, 6)
Expand Down Expand Up @@ -205,7 +206,8 @@ def on_accel_cleared(accel, path, data=None):

box.pack_start(Gtk.Separator(orientation=Gtk.Orientation.HORIZONTAL), False, False, 6)

button = Gtk.Button(_("Restore defaults"))
# Fixed: Use keyword argument instead of positional
button = Gtk.Button(label=_("Restore defaults"))
button.set_valign(Gtk.Align.CENTER)

def on_reset_clicked(button, data=None):
Expand Down