Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
fb73370
elemintion of compile warnings
kdmenk Oct 7, 2025
27b34f7
Merge branch 'linuxmint:master' into sidebar-treeview
kdmenk Oct 11, 2025
af71f0b
Extend Sidebar Places with TreeView for fi
kdmenk Oct 11, 2025
d754475
Fix sidebar warnings, remove old tree-sidebar files, update .gitignore
kdmenk Oct 11, 2025
3c39017
Ignore TreeView folder
kdmenk Oct 11, 2025
6701518
uri update from location entry in treeview
kdmenk Oct 11, 2025
d94a99e
problem with expanding nodes in uri update
kdmenk Oct 11, 2025
162b99b
comments
kdmenk Oct 11, 2025
2ef5f0a
Entered key handling and updates if local filesystem changes
kdmenk Oct 16, 2025
ca1e26e
poll for network directories
kdmenk Oct 18, 2025
1d978ac
some changes for mor sable code
kdmenk Oct 18, 2025
84b090f
some issues with the current uri selection fixed
kdmenk Oct 21, 2025
a5a0934
key up fixed
kdmenk Oct 22, 2025
465113d
existing issue while some changed hash during call of g_hash_table_ge…
kdmenk Nov 15, 2025
0f3783f
Extended FMTreeModel for usage in NemoPlacesSidebar
kdmenk Nov 17, 2025
bb72d99
extending treeview in nemo-places-sidebar.c using FMTreeModel
kdmenk Nov 18, 2025
433ea1d
Merge branch 'linuxmint:master' into sidebar-treeview
kdmenk Nov 18, 2025
ff3c843
Tree View implementation for file tree
kdmenk Nov 18, 2025
6ae2777
removed not used function
kdmenk Nov 19, 2025
75e6fcb
leak in src/nemo-places-sidebar.c
kdmenk Nov 19, 2025
130fdab
double g_signal_handler_disconnect(sidebar->window, sidebar->hidden_f…
kdmenk Nov 20, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,4 @@ debian/files
*.debhelper

obj-x86_64-linux-gnu
nemo-places-treeview/
14 changes: 3 additions & 11 deletions libnemo-private/nemo-action.c
Original file line number Diff line number Diff line change
Expand Up @@ -1431,11 +1431,7 @@ get_insertion_string (NemoAction *action,
break;
}

gchar *ret = str->str;

g_string_free (str, FALSE);

return ret;
return g_string_free (str, FALSE);
}

static GString *
Expand Down Expand Up @@ -1591,9 +1587,7 @@ get_final_label (NemoAction *action,

DEBUG ("Action Label: %s", str->str);

gchar *ret = str->str;
g_string_free (str, FALSE);
return ret;
return g_string_free (str, FALSE);
}

static gchar *
Expand All @@ -1616,9 +1610,7 @@ get_final_tt (NemoAction *action,

DEBUG ("Action Tooltip: %s", str->str);

gchar *ret = str->str;
g_string_free (str, FALSE);
return ret;
return g_string_free (str, FALSE);
}

static void
Expand Down
22 changes: 21 additions & 1 deletion libnemo-private/nemo-directory.c
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,27 @@ filtering_changed_callback (gpointer callback_data)
/* Preference about which items to show has changed, so we
* can't trust any of our precomputed directory counts.
*/
g_hash_table_foreach (directories, invalidate_one_count, NULL);
//g_hash_table_foreach (directories, invalidate_one_count, NULL);
// the hash table was changed during g_hash_table_foreach call so the following code checks for
// non existig keys cwhile processing the list
GList *keys = g_hash_table_get_keys(directories);

for (GList *l = keys; l != NULL; l = l->next) {
gpointer key = l->data;

// Prüfen ob der Key noch existiert
if (!g_hash_table_contains(directories, key))
continue;

gpointer value = g_hash_table_lookup(directories, key);
if (value == NULL)
continue; // Value bereits gelöscht

invalidate_one_count(key, value, NULL);
}

g_list_free(keys);

}

void
Expand Down
4 changes: 2 additions & 2 deletions libnemo-private/nemo-search-engine-advanced.c
Original file line number Diff line number Diff line change
Expand Up @@ -770,9 +770,9 @@ load_contents (SearchThreadData *data,
break;
}

if (chunk != NULL) {
//if (chunk != NULL) {
g_string_append_len (str, chunk, len);
}
//}
} while (!g_cancellable_is_cancelled (data->cancellable));

g_input_stream_close (stream,
Expand Down
2 changes: 1 addition & 1 deletion search-helpers/nemo-mso-to-txt.c
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ process_file (GString *collective,

gsf_input_read (GSF_INPUT (file), size, chunk);

if (chunk != NULL)
// if (chunk != NULL) always true
{
remaining -= size;
contents = g_string_append_len (contents, (const gchar *) chunk, size);
Expand Down
7 changes: 6 additions & 1 deletion src/nemo-file-management-properties.c
Original file line number Diff line number Diff line change
Expand Up @@ -568,8 +568,13 @@ bind_builder_bool (GtkBuilder *builder,
const char *widget_name,
const char *prefs)
{
GObject *object = gtk_builder_get_object (builder, widget_name);
if (!object) {
g_warning ("⚠️ bind_builder_bool: object '%s' not found in builder!", widget_name);
return;
}
g_settings_bind (settings, prefs,
gtk_builder_get_object (builder, widget_name),
object,
"active", G_SETTINGS_BIND_DEFAULT);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing objects are a programmer error, there's no point in having a warning here.

}

Expand Down
Loading
Loading