Skip to content

From #26 add open a new private window menu item #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rui8832 wants to merge 1 commit into from
Closed

From #26 add open a new private window menu item #35

rui8832 wants to merge 1 commit into from

Conversation

@rui8832
Copy link

@rui8832 rui8832 commented Nov 22, 2024

From #26 add open a new private window menu item.

github-actions[bot]
github-actions bot reviewed Nov 22, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Collaborator

LinuxServer-CI commented Nov 22, 2024

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/chromium/02e790f2-pkg-02e790f2-dev-83b6e45efdd95cdf470b0662ff12a3cfba132547-pr-35/index.html
https://ci-tests.linuxserver.io/lspipepr/chromium/02e790f2-pkg-02e790f2-dev-83b6e45efdd95cdf470b0662ff12a3cfba132547-pr-35/shellcheck-result.xml

Tag Passed
amd64-02e790f2-pkg-02e790f2-dev-83b6e45efdd95cdf470b0662ff12a3cfba132547-pr-35 ✅
arm64v8-02e790f2-pkg-02e790f2-dev-83b6e45efdd95cdf470b0662ff12a3cfba132547-pr-35 ✅

@LinuxServer-CI
Copy link
Collaborator

LinuxServer-CI commented Nov 27, 2024

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/chromium/14193214-pkg-14193214-dev-f41fef986e16bc2afaf9b82b123deb8f23a9afac-pr-35/index.html
https://ci-tests.linuxserver.io/lspipepr/chromium/14193214-pkg-14193214-dev-f41fef986e16bc2afaf9b82b123deb8f23a9afac-pr-35/shellcheck-result.xml

Tag Passed
amd64-14193214-pkg-14193214-dev-f41fef986e16bc2afaf9b82b123deb8f23a9afac-pr-35 ✅
arm64v8-14193214-pkg-14193214-dev-f41fef986e16bc2afaf9b82b123deb8f23a9afac-pr-35 ✅

@LinuxServer-CI
Copy link
Collaborator

LinuxServer-CI commented Dec 25, 2024

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/chromium/de657f4f-pkg-de657f4f-dev-61174e18783167aacde14c3b357c3ff4f15e1fd5-pr-35/index.html
https://ci-tests.linuxserver.io/lspipepr/chromium/de657f4f-pkg-de657f4f-dev-61174e18783167aacde14c3b357c3ff4f15e1fd5-pr-35/shellcheck-result.xml

Tag Passed
amd64-de657f4f-pkg-de657f4f-dev-61174e18783167aacde14c3b357c3ff4f15e1fd5-pr-35 ✅
arm64v8-de657f4f-pkg-de657f4f-dev-61174e18783167aacde14c3b357c3ff4f15e1fd5-pr-35 ✅

thespad
thespad reviewed Jan 8, 2025
View reviewed changes
root/defaults/menu.xml
<menu id="root-menu" label="MENU">
<item label="xterm" icon="/usr/share/pixmaps/xterm-color_48x48.xpm"><action name="Execute"><command>/usr/bin/xterm</command></action></item>
<item label="Chromium" icon="/usr/share/icons/hicolor/48x48/apps/chromium.png"><action name="Execute"><command>/usr/bin/wrapped-chromium</command></action></item>
<item label="Chromium Private" icon="/defaults/icons/chrom-incognito-48x48.png"><action name="Execute"><command>/usr/bin/wrapped-chromium --incognito</command></action></item>
Copy link
Member

@thespad thespad Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon path is incorrect

thespad
thespad reviewed Jan 8, 2025
View reviewed changes
root/defaults/icons/chromium-48x48.png
Copy link
Member

@thespad thespad Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image isn't necessary, the Chromium icon is already being sourced from the install.

thespad
thespad requested changes Jan 8, 2025
View reviewed changes
Copy link
Member

@thespad thespad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the above comments

@LinuxServer-CI
Copy link
Collaborator

LinuxServer-CI commented Jan 21, 2025

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/chromium/e3efdad3-pkg-e3efdad3-dev-a61b344ca09fc6be0d57272c7107bacf1ebaab3e-pr-35/index.html
https://ci-tests.linuxserver.io/lspipepr/chromium/e3efdad3-pkg-e3efdad3-dev-a61b344ca09fc6be0d57272c7107bacf1ebaab3e-pr-35/shellcheck-result.xml

Tag Passed
amd64-e3efdad3-pkg-e3efdad3-dev-a61b344ca09fc6be0d57272c7107bacf1ebaab3e-pr-35 ✅
arm64v8-e3efdad3-pkg-e3efdad3-dev-a61b344ca09fc6be0d57272c7107bacf1ebaab3e-pr-35 ✅

@LinuxServer-CI
Copy link
Collaborator

LinuxServer-CI commented Feb 17, 2025

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/chromium/6c8c2571-pkg-6c8c2571-dev-e93090823fa8f8340a580da04539a7884e80b2a3-pr-35/index.html
https://ci-tests.linuxserver.io/lspipepr/chromium/6c8c2571-pkg-6c8c2571-dev-e93090823fa8f8340a580da04539a7884e80b2a3-pr-35/shellcheck-result.xml

Tag Passed
amd64-6c8c2571-pkg-6c8c2571-dev-e93090823fa8f8340a580da04539a7884e80b2a3-pr-35 ✅
arm64v8-6c8c2571-pkg-6c8c2571-dev-e93090823fa8f8340a580da04539a7884e80b2a3-pr-35 ✅

@LinuxServer-CI
Copy link
Collaborator

LinuxServer-CI commented Mar 15, 2025

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/chromium/9dd661e2-pkg-9dd661e2-dev-e9dc9ad5876f8507b80fe87c7f3b42b6dde58ad5-pr-35/index.html
https://ci-tests.linuxserver.io/lspipepr/chromium/9dd661e2-pkg-9dd661e2-dev-e9dc9ad5876f8507b80fe87c7f3b42b6dde58ad5-pr-35/shellcheck-result.xml

Tag Passed
amd64-9dd661e2-pkg-9dd661e2-dev-e9dc9ad5876f8507b80fe87c7f3b42b6dde58ad5-pr-35 ✅
arm64v8-9dd661e2-pkg-9dd661e2-dev-e9dc9ad5876f8507b80fe87c7f3b42b6dde58ad5-pr-35 ✅

@thespad
Copy link
Member

thespad commented Apr 6, 2025

No response from OP

@thespad thespad closed this Apr 6, 2025
@LinuxServer-CI LinuxServer-CI moved this from PRs to Done in Issue & PR Tracker Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@thespad thespad thespad requested changes

Assignees

No one assigned

Labels

None yet

Projects

Issue & PR Tracker
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rui8832 @LinuxServer-CI @thespad