Link Settings' Livebook version to GitHub release#3147
Link Settings' Livebook version to GitHub release#3147jonatanklosko merged 5 commits intolivebook-dev:mainfrom
Conversation
|
|
jonatanklosko
left a comment
jonatanklosko
left a comment
There was a problem hiding this comment.
Sounds good to me! I dropped one minor comment. Also, please sign the CLA, and then it's good to merge.
| </.labeled_text> | ||
| <.labeled_text label="Livebook"> | ||
| v{Livebook.Config.app_version()} | ||
| <% release_info = Livebook.Config.github_release_info() %> |
There was a problem hiding this comment.
Let's move this to an assign @release_info that we can set on mount.
It's best to avoid defining variables like this in HEEx. In this case it's actually fine, but it's simpler to avoid it altogether :)
| <.labeled_text label="Livebook"> | ||
| v{Livebook.Config.app_version()} | ||
| <a href={"https://github.com/#{@release_info.repo}/releases/tag/v#{@release_info.version}"} | ||
| class="underline hover:no-underline" |
There was a problem hiding this comment.
Note the styling is to have the link be underlined by default and no underline on hover. This is consistent with other links on the page (see L57-59), though personally I find it looks a bit out of place.
There was a problem hiding this comment.
I agree it looks weird, I think mostly because it's not a link within text paragraph, but standalone. I changed it to show an external link icon instead (and did the same for the other one you mentioned):
3 participants
Was running Livebook via the macOS app and it updated to the latest version. I wanted an easy way to see the changes from within Livebook, and thought the Livebook version can link to the GitHub Release which contains a changelog.
Note this link will 404 when running Livebook from the main branch as there is no GitHub Release for unreleased dev versions. I think that's fine though.