Support location output parsed as CSV#49
Merged
josevalim merged 1 commit intolivebook-dev:mainfrom Nov 12, 2025
Merged
Conversation
Newer versions of Req will attempt to decode the body based on the path name if the content-type is `application/octet-stream`. Since this is being hardcoded to `*-manifest.csv`, that means it will be decoded and fail the `String` function calls that were previously used in `ReqAthena.S3.get_locations/2`. This forces `decode_body: false` for this specific request since it is expected to only be a newline delineated string
Contributor
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions of Req will attempt to decode the body based on the path name if the content-type is
application/octet-stream. Since this is being hardcoded to*-manifest.csv, that means it will be decoded and fail theStringfunction calls that were previously used inReqAthena.S3.get_locations/2.This forces
decode_body: falsefor this specific request since it is expected to only be a newline delineated string