Use returned DataManifestLocation if available#50
Merged
josevalim merged 2 commits intolivebook-dev:mainfrom Nov 12, 2025
Merged
Use returned DataManifestLocation if available#50josevalim merged 2 commits intolivebook-dev:mainfrom
DataManifestLocation if available#50josevalim merged 2 commits intolivebook-dev:mainfrom
Conversation
Fixes livebook-dev#42 In some situations, the manifest file may be a slightly different path than what is set in `output_locations` (reasons not fully known). This would cause failures fetching the locations of results since the manifest would not exist due to the hardcoded path. This changes to use the `DataManifestLocation` key if it is returned in the results rather than assuming the path
Contributor
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42
In some situations, the manifest file may be a slightly different path than what is set in
output_locations(reasons not fully known). This would cause failures fetching the locations of results since the manifest would not exist due to the hardcoded path.This changes to use the
DataManifestLocationkey if it is returned in the results rather than assuming the path.Sample JSON response
{ "QueryExecution": { "EngineVersion": { "EffectiveEngineVersion": "Athena engine version 3", "SelectedEngineVersion": "Athena engine version 3" }, "Query": "UNLOAD (SELECT count(*) FROM my_fav_table\n)\nTO 's3://aws-athena-query-results-123456789-us-east-1/livebook-2025-11-11T23:18:46.337381Z/results'\nWITH (format = 'PARQUET')", "QueryExecutionContext": { "Database": "my_fav_db" }, "QueryExecutionId": "5b6d4bd6-d207-46a4-b1e3-84656c16ad5a", "ResultConfiguration": { "OutputLocation": "s3://aws-athena-query-results-123456789-us-east-1/livebook-2025-11-11T23:18:46.337381Z/5b6d4bd6-d207-46a4-b1e3-84656c16ad5a" }, "ResultReuseConfiguration": { "ResultReuseByAgeConfiguration": { "Enabled": false } }, "StatementType": "DML", "Statistics": { "DataManifestLocation": "s3://aws-athena-query-results-123456789-us-east-1/livebook-2025-11-11T23:18:46.337381Z/5b6d4bd6-d207-46a4-b1e3-84656c16ad5a-manifest.csv", "DataScannedInBytes": 212019779, "EngineExecutionTimeInMillis": 2903, "QueryPlanningTimeInMillis": 667, "QueryQueueTimeInMillis": 128, "ResultReuseInformation": { "ReusedPreviousResult": false }, "ServicePreProcessingTimeInMillis": 74, "ServiceProcessingTimeInMillis": 43, "TotalExecutionTimeInMillis": 3148 }, "Status": { "CompletionDateTime": 1762903129.907, "State": "SUCCEEDED", "SubmissionDateTime": 1762903126.759 }, "SubstatementType": "UNLOAD", "WorkGroup": "primary" }, "QueryExecutionDetail": { "OutputLocation": "s3://aws-athena-query-results-123456789-us-east-1/livebook-2025-11-11T23:18:46.337381Z/5b6d4bd6-d207-46a4-b1e3-84656c16ad5a", "Query": "UNLOAD (SELECT count(*) FROM my_fav_table\n)\nTO 's3://aws-athena-query-results-123456789-us-east-1/livebook-2025-11-11T23:18:46.337381Z/results'\nWITH (format = 'PARQUET')", "QueryExecutionContext": { "Database": "my_fav_db" }, "QueryExecutionId": "5b6d4bd6-d207-46a4-b1e3-84656c16ad5a", "ResultConfiguration": { "OutputLocation": "s3://aws-athena-query-results-123456789-us-east-1/livebook-2025-11-11T23:18:46.337381Z/5b6d4bd6-d207-46a4-b1e3-84656c16ad5a" }, "Stats": { "EngineExecutionTimeInMillis": 2903, "ProcessedBytes": 212019779, "ProcessedInputBytes": 2659877869, "ProcessedInputRows": 189833636, "ProcessedRows": 189833636, "ResultReuseInformation": { "ReusedPreviousResult": false } }, "Status": { "CompletionDateTime": 1762903129.907, "State": "SUCCEEDED", "SubmissionDateTime": 1762903126.759 }, "WorkGroup": "primary" } }