Skip to content

Conversation

@chenosaurus
Copy link
Contributor

  • Allow h265://HOST:PORT to be used with the --publish flag to publish a pre-encoded h265 video stream.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the simulcast functionality to support H.265/HEVC codec in addition to the existing H.264 support. Users can now publish H.265 video streams using the h265:// URL scheme and create simulcast tracks with multiple H.265 layers.

Key changes:

  • Extended the simulcast URL regex to accept both h264:// and h265:// protocols
  • Added codec validation to ensure all simulcast layers use the same codec (either all H.264 or all H.265)
  • Updated documentation and usage strings to reflect H.265 support

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
cmd/lk/room.go Updated simulcast URL regex and validation logic to support both h264 and h265 codecs; added codec consistency checks
cmd/lk/join.go Extended parseSimulcastURL, createSimulcastVideoTrack, and related functions to handle h265 codec; updated publishSocket to map h265 to the appropriate MIME type
cmd/lk/join_test.go Added test cases for h265 URLs and updated test descriptions to reflect support for both codecs
README.md Updated documentation to mention H.265/HEVC support and codec compatibility requirements

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants