Skip to content

Conversation

rektdeckard
Copy link
Member

@rektdeckard rektdeckard commented Aug 26, 2025

https://linear.app/livekit/issue/DPRO-377/add-nodejs-reference-docs

  • Sets up GitHub workflow docs deployment for both server-sdk-js and rtc-node

Copy link

changeset-bot bot commented Aug 26, 2025

⚠️ No Changeset found

Latest commit: a4e0021

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rektdeckard rektdeckard requested review from bcherry and lukasIO August 26, 2025 18:08
Copy link
Contributor

@bcherry bcherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the rust sdks update intentional? there's also a crypto update that seems unlikely to be related to docs.

edit: nevermind I see the description mentions the other fixes. please submit them in separate PRs.

@lukasIO
Copy link
Contributor

lukasIO commented Aug 28, 2025

sorry, thought I had submitted the review but my review comments were stuck in "pending" :/

@lukasIO
Copy link
Contributor

lukasIO commented Aug 28, 2025

@rektdeckard since last week most CI workflows were broken. I extracted the bare minimum of necessary fixes in #529.
This should make it easier to reduce the necessary changes in this PR

@rektdeckard rektdeckard force-pushed the tobias/dpro-377-add-nodejs-reference-docs branch from 565294f to d14ba5b Compare August 28, 2025 18:36
@rektdeckard rektdeckard force-pushed the tobias/dpro-377-add-nodejs-reference-docs branch from d14ba5b to 7688a33 Compare August 28, 2025 18:48
@rektdeckard
Copy link
Member Author

@lukasIO removed the non-docs changes, and since we are pinning both livekit-rtc and livekit-server-sdk to use the same version of Typescript, I thought it best to use the workspace catalog for it so it can be updated in one place.

@rektdeckard rektdeckard requested a review from lukasIO August 28, 2025 18:49
rektdeckard and others added 3 commits August 28, 2025 12:50
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@lukasIO
Copy link
Contributor

lukasIO commented Aug 29, 2025

thanks for moving it to the catalog! I had the same idea and included a couple more shared deps here #532

I'll wait with merging #532 until you've merged this one

contents: read

on:
workflow_dispatch:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like triggering publishing of docs is exclusively a manual process.

It would be great if we could automate it as part of the release workflow, i.e. if a package got published, also publish the latest docs, so that the docs are always up to date with the latest release without us having to remember explicitly publishing the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants