Skip to content

Introduce AudioStream.from_participant + VideoStream.from_participant #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 9, 2024
Merged

Introduce AudioStream.from_participant + VideoStream.from_participant #229

merged 13 commits into from
Sep 9, 2024

Conversation

keepingitneil
Copy link
Contributor

@keepingitneil keepingitneil commented Aug 1, 2024 •
edited
Loading

This PR introduces the following APIs:
AudioStream.from_participant and VideoStream.from_participant

@keepingitneil keepingitneil changed the title Introduce extension APIs for common usecases Introduce wait_for_participant and wait_for_track_publication APIs Aug 2, 2024
@keepingitneil keepingitneil marked this pull request as ready for review August 2, 2024 16:47
@keepingitneil keepingitneil marked this pull request as draft August 2, 2024 18:04
@keepingitneil keepingitneil changed the title Introduce wait_for_participant and wait_for_track_publication APIs Introduce create_audio_stream and create_video_stream APIs Aug 5, 2024
@keepingitneil keepingitneil changed the title Introduce create_audio_stream and create_video_stream APIs Introduce AudioStream.from_participant + VideoStream.from_participant Sep 6, 2024
@keepingitneil keepingitneil marked this pull request as ready for review September 6, 2024 00:14
@keepingitneil keepingitneil requested a review from a team September 6, 2024 00:15
theomonnom
theomonnom reviewed Sep 6, 2024
View reviewed changes
theomonnom
theomonnom reviewed Sep 9, 2024
View reviewed changes
livekit-rtc/livekit/rtc/audio_stream.py Outdated
num_channels: int = 1,
**kwargs,
) -> None:
self._track = track
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self._track = track
self._track: Track | None = track

@keepingitneil keepingitneil merged commit a475312 into main Sep 9, 2024
10 of 11 checks passed
@keepingitneil keepingitneil deleted the neil/ext branch September 9, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theomonnom theomonnom theomonnom approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@keepingitneil @theomonnom