Skip to content

don't use the logger to print panic #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2024
Merged

don't use the logger to print panic #279

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
547ac59
wip
theomonnom Oct 4, 2024
fca7411
flush
theomonnom Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion livekit-rtc/livekit/rtc/_ffi_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

import signal
import asyncio
import sys
from contextlib import ExitStack
import ctypes
import importlib.resources
Expand Down Expand Up @@ -166,7 +167,7 @@ def ffi_event_callback(

return # no need to queue the logs
elif which == "panic":
logger.critical("Panic: %s", event.panic.message)
print("FFI Panic: ", event.panic.message, file=sys.stderr)
# We are in a unrecoverable state, terminate the process
os.kill(os.getpid(), signal.SIGTERM)
return
Expand Down
Loading