Skip to content

fix typing of track_publications using covariant Mapping #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2024
Merged

fix typing of track_publications using covariant Mapping #287

merged 2 commits into from
Oct 9, 2024

Conversation

theomonnom
Copy link
Member

@theomonnom theomonnom commented Oct 9, 2024 •
edited
Loading

  • also makes it readonly
  • Participant is now ABC
  • did the same for room.remote_participants

@theomonnom theomonnom changed the title fix typing of track_publications fix typing of track_publications using covariant Mapping Oct 9, 2024
@theomonnom theomonnom requested a review from a team October 9, 2024 23:42
@theomonnom theomonnom merged commit c1111ac into main Oct 9, 2024
11 checks passed
@theomonnom theomonnom deleted the theo/mappings branch October 9, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theomonnom @davidzhao