Skip to content

Fix: updateIngress incorrectly sets participantIdentity to null #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2025
Merged

Fix: updateIngress incorrectly sets participantIdentity to null #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0dc58b
Fix: correctly assign participantIdentity in updateIngress
juancarmore Feb 24, 2025
b5bafbe
Update IngressServiceClient.kt
davidzhao Feb 24, 2025
f4c3cc4
Create fast-teachers-buy.md
davidzhao Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fast-teachers-buy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"server-sdk-kotlin": patch
---

Fix: updateIngress incorrectly sets participantIdentity to null
4 changes: 2 additions & 2 deletions src/main/kotlin/io/livekit/server/IngressServiceClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2024 LiveKit, Inc.
* Copyright 2024-2025 LiveKit, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -119,7 +119,7 @@ class IngressServiceClient(
this.roomName = roomName
}

if (participantIdentity == null) {
if (participantIdentity != null) {
this.participantIdentity = participantIdentity
}

Expand Down
Loading