lkl: Fix builds without CONFIG_PCI #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, LKL cannot be built without selecting CONFIG_PCI. This is because pci.c is compiled unconditionally even if CONFIG_PCI is not specified. arch/lkl/drivers/pci.c: In function ‘lkl_pci_probe’: arch/lkl/drivers/pci.c:219:15: error: implicit declaration of function ‘pci_scan_bus’ [-Wimplicit-function-declaration] 219 | bus = pci_scan_bus(0, &lkl_pci_root_ops, (void *)dev); | ^~~~~~~~~~~~ This commit fixes the problem by compiling pci.c conditionally. After this commit, pci.c will only be compiled if CONFIG_PCI is on. Signed-off-by: Ruihan Li <[email protected]>
tavip
approved these changes
Apr 25, 2025
thehajime
approved these changes
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, LKL cannot be built without selecting CONFIG_PCI. This is because pci.c is compiled unconditionally even if CONFIG_PCI is not specified.
This commit fixes the problem by compiling pci.c conditionally. After this commit, pci.c will only be compiled if CONFIG_PCI is on.