[Datapath] Prevent FoldAddIntoCompress from introducing datapath ops from pure comb ops #9178
+21
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from pure comb ops This commit fixes FoldAddIntoCompress canonicalization pattern that would introduce datapath.compress operations when canonicalizing pure comb.add operations that have no datapath operands. The fix is not still ideal since the canonicalization is registered for comb.add. It should be implementeded as a caonicalization for datapath.compress or standalone pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes FoldAddIntoCompress canonicalization pattern that would introduce datapath.compress operations when canonicalizing pure comb.add operations that have no datapath operands. This was exposed by #9177 which I added CSE between DatapathToComb and canonicalization, datapath operations are introduced by canonicalization after DatapathToComb.
The fix is not still ideal since the canonicalization is registered for comb.add. It should be implementeded as a caonicalization for datapath.compress or standalone pass.