Skip to content

[CIR][CIRGen] Handle Address Space Casting on builtin allocas #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RiverDave merged 1 commit into from
Dec 15, 2025
+34 −1
Merged

[CIR][CIRGen] Handle Address Space Casting on builtin allocas #2064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1770,7 +1770,9 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
mlir::ptr::MemorySpaceAttrInterface EAS = cir::toCIRLangAddressSpaceAttr(
&getMLIRContext(), E->getType()->getPointeeType().getAddressSpace());
if (EAS != AAS) {
assert(false && "Non-default address space for alloca NYI");
mlir::Type TY = CGM.getTypes().convertType(E->getType());
return RValue::get(getTargetHooks().performAddrSpaceCast(
*this, AllocaAddr, AAS, EAS, TY));
}

// Bitcast the alloca to the expected type.
Expand Down
31 changes: 31 additions & 0 deletions clang/test/CIR/CodeGen/dynamic-alloca-with-address-space.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -fclangir -emit-cir %s -o %t.cir
// RUN: FileCheck --input-file=%t.cir %s --check-prefix=CIR

// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -fclangir -emit-llvm %s -o %t.ll
// RUN: FileCheck --input-file=%t.ll %s --check-prefix=LLVM

// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -emit-llvm %s -o %t.ll
// RUN: FileCheck --input-file=%t.ll %s --check-prefix=OGCG

void allocas(unsigned long n) {
char *a = (char *)__builtin_alloca(n);
char *uninitialized_a = (char *)__builtin_alloca_uninitialized(n);
}

// CIR-LABEL: cir.func {{.*}} @allocas
// CIR: %[[ALLOCA1:.*]] = cir.alloca !u8i, !cir.ptr<!u8i>, {{.*}} ["bi_alloca"]
// CIR: cir.cast bitcast %[[ALLOCA1]] : !cir.ptr<!u8i> -> !cir.ptr<!void>
// CIR: %[[ALLOCA2:.*]] = cir.alloca !u8i, !cir.ptr<!u8i>, {{.*}} ["bi_alloca"]
// CIR: cir.cast bitcast %[[ALLOCA2]] : !cir.ptr<!u8i> -> !cir.ptr<!void>

// LLVM-LABEL: define {{.*}} void @allocas(i64 %{{.*}})
// LLVM: %[[BI_ALLOCA1:.*]] = alloca i8, i64 %{{.*}}, align 8, addrspace(5)
// LLVM: addrspacecast ptr addrspace(5) %[[BI_ALLOCA1]] to ptr
// LLVM: %[[BI_ALLOCA2:.*]] = alloca i8, i64 %{{.*}}, align 8, addrspace(5)
// LLVM: addrspacecast ptr addrspace(5) %[[BI_ALLOCA2]] to ptr

// OGCG-LABEL: define {{.*}} void @allocas(i64 {{.*}} %n)
// OGCG: %[[BI_ALLOCA1:.*]] = alloca i8, i64 %{{.*}}, align 8, addrspace(5)
// OGCG: addrspacecast ptr addrspace(5) %[[BI_ALLOCA1]] to ptr
// OGCG: %[[BI_ALLOCA2:.*]] = alloca i8, i64 %{{.*}}, align 8, addrspace(5)
// OGCG: addrspacecast ptr addrspace(5) %[[BI_ALLOCA2]] to ptr