- 
                Notifications
    You must be signed in to change notification settings 
- Fork 15k
[AMDGPU]: Unpack packed instructions overlapped by MFMAs post-RA scheduling #157968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            jrbyrnes
  merged 18 commits into
  llvm:main
from
akadutta:users/akadutta/amdgpu/unpack_non_coissue_insts_postRA
  
      
      
   
  Sep 19, 2025 
      
    
  
     Merged
                    Changes from 7 commits
      Commits
    
    
            Show all changes
          
          
            18 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      c15104f
              
                unpack packed instructions overlapped by MFMAs post-RA scheduling
              
              
                akadutta fb05da7
              
                format error fix and unpack candidate selection condition change
              
              
                akadutta bbefcfb
              
                code comments, variable and function re-naming, minor code optimizations
              
              
                akadutta 880ed6b
              
                Merge branch 'main' into users/akadutta/amdgpu/unpack_non_coissue_ins…
              
              
                akadutta f71631d
              
                MIR tests for pk_add and pk_fma
              
              
                akadutta 6f5c6a5
              
                check if unpacking can introduce dependencies, improve candidate sele…
              
              
                akadutta ea85eb7
              
                update MIR test cmd
              
              
                akadutta 4995f00
              
                remove use of hard coded operand idx
              
              
                akadutta 05d0c75
              
                update test
              
              
                akadutta 88e3c6d
              
                direct and transitive dependency on MFMA def, reg kill logic, new tests
              
              
                akadutta 56b505f
              
                update condition for MFMA dependence check
              
              
                akadutta 3ecc5da
              
                update code comments
              
              
                akadutta 48cf50c
              
                update return conditions, reduce LOC
              
              
                akadutta 022fa2d
              
                new tests, reduced nesting, cleanup
              
              
                akadutta 720468f
              
                update tests, update unpacking selection condition
              
              
                akadutta 4685911
              
                minor fixes
              
              
                akadutta 3e016ca
              
                update failing test
              
              
                akadutta 1b2bf71
              
                clang-formatted
              
              
                akadutta File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to extract this information from the scheduler model without maintaining this list of instructions? i.e. there should be some execution resource you can check if the instruction uses