[MLIR][Bazel] correctly fix bazel build after 59e74a0 #160539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makslevental
requested review from
rupprecht,
keith and
aaronmondal
as code owners
makslevental
force-pushed
the
users/makslevental/revert-revert
branch
from
97743f7 to
7d43e6e
Compare
makslevental
requested review from
superbobry,
jpienaar and
bartchr808
and removed request for
superbobry,
bartchr808 and
jpienaar
bartchr808
approved these changes
Sep 24, 2025
|
@llvm/pr-subscribers-mlir Author: Maksim Levental (makslevental) Changes#160508 wasn't the correct fix - the fix just disabled the test because is now alwaysFalse (if not "0" is always False). This PR is the correct fix.
Full diff: https://github.com/llvm/llvm-project/pull/160539.diff 2 Files Affected:
diff --git a/mlir/test/lit.site.cfg.py.in b/mlir/test/lit.site.cfg.py.in
index c7a0bbe114fe2..1aaf7989e3ce5 100644
--- a/mlir/test/lit.site.cfg.py.in
+++ b/mlir/test/lit.site.cfg.py.in
@@ -60,7 +60,7 @@ config.mlir_run_cuda_sm80_tests = @MLIR_RUN_CUDA_SM80_TESTS@
config.mlir_run_cuda_sm80_lt_tests = @MLIR_RUN_CUDA_SM80_LT_TESTS@
config.mlir_run_cuda_sm90_tests = @MLIR_RUN_CUDA_SM90_TESTS@
config.mlir_include_integration_tests = @MLIR_INCLUDE_INTEGRATION_TESTS@
-config.llvm_shared_libs_build = "@BUILD_SHARED_LIBS@"
+config.llvm_shared_libs_build = @BUILD_SHARED_LIBS@
config.arm_emulator_executable = "@ARM_EMULATOR_EXECUTABLE@"
# Some tests marked with 'UNSUPPORTED: target=aarch64{{.*}}' are still run when
# configured with ARM_EMULATOR_EXECUTABLE and the default target is not aarch64.
diff --git a/utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
index 469fcee8d9748..7e36d0ba787b6 100644
--- a/utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
@@ -31,6 +31,7 @@ expand_template(
"@LIT_SITE_CFG_IN_HEADER@": LIT_SITE_CFG_IN_HEADER,
"@LLVM_TOOLS_DIR@": package_path("//llvm:BUILD"),
"@ENABLE_SHARED@": "1",
+ "@BUILD_SHARED_LIBS@": "1",
"@ENABLE_ASSERTIONS@": "1",
"@MLIR_SOURCE_DIR@": package_path("//mlir:BUILD"),
"@MLIR_TOOLS_DIR@": package_path("//mlir:BUILD"),
|
makslevental
force-pushed
the
users/makslevental/revert-revert
branch
from
7d43e6e to
843567a
Compare
makslevental
changed the title
superbobry
approved these changes
Sep 24, 2025
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
llvm#160508 wasn't the correct fix - the fix just disabled the test because https://github.com/llvm/llvm-project/blob/59e74a0749203998b3e5fd9bc6525de148db28ab/mlir/test/Examples/standalone/lit.local.cfg#L18 is now always `False` (`if not "0"` is always `False`). This PR is the correct fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#160508 wasn't the correct fix - the fix just disabled the test because
llvm-project/mlir/test/Examples/standalone/lit.local.cfg
Line 18 in 59e74a0
False(if not "0"is alwaysFalse). This PR is the correct fix.