[Bolt] Use fully qualified docker image name (NFC) #162154
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbvictor
requested review from
aaupov,
ayermolo,
maksfb,
paschalis-mpeis,
rafaelauler,
yota9 and
yozhu
as code owners
|
@llvm/pr-subscribers-bolt Author: Baranov Victor (vbvictor) ChangesBased on #162007 (comment), we should avoid having short links in docker images. Full diff: https://github.com/llvm/llvm-project/pull/162154.diff 1 Files Affected:
diff --git a/bolt/utils/docker/Dockerfile b/bolt/utils/docker/Dockerfile
index c58e1a533df94..86d1be2141655 100644
--- a/bolt/utils/docker/Dockerfile
+++ b/bolt/utils/docker/Dockerfile
@@ -1,4 +1,4 @@
-FROM ubuntu:24.04 AS builder
+FROM docker.io/library/ubuntu:24.04 AS builder
ARG DEBIAN_FRONTEND=noninteractive
ENV TZ=UTC
@@ -25,6 +25,6 @@ RUN mkdir build && \
ninja check-bolt && \
ninja install-llvm-bolt install-merge-fdata install-bolt_rt
-FROM ubuntu:24.04
+FROM docker.io/library/ubuntu:24.04
COPY --from=builder /home/bolt/install /usr/local
|
aaupov
approved these changes
Oct 6, 2025
svkeerthy
pushed a commit
that referenced
this pull request
Oct 9, 2025
Based on #162007 (comment), we should avoid having short links in docker images.
clingfei
pushed a commit
to clingfei/llvm-project
that referenced
this pull request
Oct 10, 2025
Based on llvm#162007 (comment), we should avoid having short links in docker images.
akadutta
pushed a commit
to akadutta/llvm-project
that referenced
this pull request
Oct 14, 2025
Based on llvm#162007 (comment), we should avoid having short links in docker images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #162007 (comment), we should avoid having short links in docker images.