Skip to content

Conversation

kkwli
Copy link
Contributor

@kkwli kkwli commented Nov 5, 2024

No description provided.

@kkwli kkwli self-assigned this Nov 5, 2024
Copy link
Contributor

@madanial0 madanial0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

'factory' : UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory(
clean=True,
depends_on_projects=['llvm', 'mlir', 'clang', 'flang'],
depends_on_projects=['llvm', 'mlir', 'clang', 'flang','openmp'],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: add a space to keep the same format as the previous entries.

@kkwli kkwli merged commit a902e09 into llvm:main Nov 6, 2024
2 checks passed
@kkwli kkwli deleted the update-config branch November 6, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants