Skip to content

Conversation

@Keenuts
Copy link
Contributor

@Keenuts Keenuts commented Jan 28, 2025

This PR expands the documentation around GCP and the K8 cluster running linux/windows runners.

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments (mostly nits).

This looks really awesome! Thank you very much for putting time into writing proper documentation.

@Keenuts
Copy link
Contributor Author

Keenuts commented Jan 29, 2025

Thanks, feedback applied!

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Keenuts Keenuts merged commit 267ca50 into llvm:main Jan 31, 2025
2 checks passed
@Keenuts Keenuts deleted the gcp-docs branch January 31, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants